Skip to content

Preserve empty URL segment metadata handling without requiring URL prefix#24221

Merged
sgiehl merged 2 commits into5.x-devfrom
split/actions-filter-empty-url-segment
Mar 16, 2026
Merged

Preserve empty URL segment metadata handling without requiring URL prefix#24221
sgiehl merged 2 commits into5.x-devfrom
split/actions-filter-empty-url-segment

Conversation

@sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 13, 2026

Description

In Actions DataTable filter, URL metadata handling was gated by && $urlPrefix.
If prefix was missing, the branch did not run, so empty/not-defined URL rows did not get segment = null metadata.

Empty/not-defined URL rows should consistently avoid segment actions, independent of URL prefix availability.

refs #24191

Checklist

  • [✔] I have understood, reviewed, and tested all AI outputs before use
  • [✔] All AI instructions respect security, IP, and privacy rules

Review

@sgiehl sgiehl added this to the 5.9.0 milestone Mar 13, 2026
@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Stability For issues that make Matomo more stable and reliable to run for sys admins. labels Mar 13, 2026
@sgiehl sgiehl marked this pull request as ready for review March 13, 2026 16:35
@sgiehl sgiehl requested a review from a team March 13, 2026 16:35
@sgiehl sgiehl merged commit 67d8af2 into 5.x-dev Mar 16, 2026
49 of 51 checks passed
@sgiehl sgiehl deleted the split/actions-filter-empty-url-segment branch March 16, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Stability For issues that make Matomo more stable and reliable to run for sys admins.

Development

Successfully merging this pull request may close these issues.

2 participants